Thanks! I'll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can't participate on GitHub, but those aren't the only issues I've found. (e.g. there's also ?format=jpg&thumbnail=96 on non-pictrs links and a text handling issue with angle brackets...)
no lemmy community for mlmym yet, that's good idea.
do you have an example of that thumbnail issue?
I'm having trouble finding an example of the thumbnail issue again right now but I was seeing the pictrs conversion parameters passed to URLs from catbox.moe, i.postimg.cc, and other sources in the CSS for the thumbnail when I reported the issue to Tiff ~3 weeks ago. It's possible that it got fixed/suppressed by another change since then though. (0.0.44 was deployed a few hours ago and I think there may have also been a beta patch bump for the lemmy backend at some point since I reported the issue originally in our local support community.)
I'll let you know if I see it pop up again.
For the text handling issue, I was seeing text like " by in " (i.e. " by in " if it still happens) getting misinterpreted as raw HTML instead of being escaped. (i.e. `` was showing up in the HTML output for the page.)
You may recognize that text as the pattern for a recently fixed bug in the user profiles; I found the text handling issue while trying to explain the other issue to Tiff a few weeks ago.
Will edit this comment immediately after posting to let you know if I still see the text issue.
Note that it's making a request to kbin.social with ?format=jpg&thumbnail=96 parameters in the CSS -- which results in the full image being loaded since kbin doesn't run pictrs.
The versions in use on reddthat (according to the settings page) are:
Thanks! I'll go ask Tiff about getting reddthat updated later.
BTW, is there a community for discussion of mlmym itself somewhere on lemmy? I can't participate on GitHub, but those aren't the only issues I've found. (e.g. there's also
?format=jpg&thumbnail=96on non-pictrs links and a text handling issue with angle brackets...)no lemmy community for mlmym yet, that's good idea.
do you have an example of that thumbnail issue?
I'm having trouble finding an example of the thumbnail issue again right now but I was seeing the pictrs conversion parameters passed to URLs from catbox.moe, i.postimg.cc, and other sources in the CSS for the thumbnail when I reported the issue to Tiff ~3 weeks ago. It's possible that it got fixed/suppressed by another change since then though. (0.0.44 was deployed a few hours ago and I think there may have also been a beta patch bump for the lemmy backend at some point since I reported the issue originally in our local support community.)
I'll let you know if I see it pop up again.
For the text handling issue, I was seeing text like " by in " (i.e.
" by in "if it still happens) getting misinterpreted as raw HTML instead of being escaped. (i.e. `` was showing up in the HTML output for the page.)You may recognize that text as the pattern for a recently fixed bug in the user profiles; I found the text handling issue while trying to explain the other issue to Tiff a few weeks ago.
Will edit this comment immediately after posting to let you know if I still see the text issue.
EDIT: I still see the text issue show up in this comment. https://old.reddthat.com/comment/10370610
I ran into an example of the thumbnail issue again today -- this time on a post from kbin: https://old.reddthat.com/post/19193476
The thumbnail looks like this in the HTML:
Note that it's making a request to kbin.social with
?format=jpg&thumbnail=96parameters in the CSS -- which results in the full image being loaded since kbin doesn't run pictrs.The versions in use on reddthat (according to the settings page) are:
lemmy: 0.19.4-beta.7
mlmym: 0.0.44
This kinda looks like an issue between lemmy and kbin. The issue is present on the lemmy ui as well. The
?format=jpg&thumbnail=96parameter being there doesn't have an effect here. The issue is the thumbnail_url is reported wrong. You can see that here. The thumbnail_url should be: https://kbin.social/media/cache/resolve/entry_thumb/60/a4/60a45b8ff88b1b2e3a0f77b701feb323c5bbfb7ceeb75154ea7df5d6eea15ef8.jpg We could try and use some regex to lookout for kbin images and rewrite the thumbnail_url, but it should probably just be fixed upstream.Found this github issue which might be related: https://github.com/LemmyNet/lemmy/issues/3775