Merge then review

agilob@programming.dev to Programmer Humor@programming.dev – 722 points –

Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don't let code become stale.

138

You are viewing a single comment

Get the value to production

Ugh, not this SAFe Agile (tm) cultist bullshit. The "value" is working, bug free code, which you get when you put it through review and QA before it gets to production.

There is no value in spaghetti piled on top of rotten spaghetti. Tech iCal debt is real and if you're just shippin it and plan to fix it later, y'all gonna have a bad time. Nothing more permanent than a temporary workaround.

There's often features and bug fixes worth more than the ones introduced in the PR. I've yet to see bug free code just because it's went through review and QA.

Surely you've seen bugs caught because code went through review and QA though. Those are bugs that would go into production if following the "advice" in this post.

I'm saying identify the bugs through review, and fix them. Just do it in a new PR unless they are critical