I just made my first Lemmy PR

rosenjcb@lemmy.world to Technology@lemmy.world – 182 points –
Add Toast Messages for Bad Logins by rosenjcb · Pull Request #1874 · LemmyNet/lemmy-ui
github.com

Let's gooooooooo

20

You are viewing a single comment

There should be an error, but it shouldn't say whether it was the email or password that was wrong.

An attacker would still know the account exists, and they would know the password did not match.

_Or_ you're assuring them that specific password is used by some account, just not this one. Which is even worse.

Read the comment you're responding to, again. Nothing about their suggestion leads to either of these scenarios.

Right, I misread "shouldn't" for "should".