Not a bad idea! The attack vector issue they mention in the PR comments is valid, though. Not displaying those errors gives an attacker no confirmation that a user whose account they're trying to attack exists, if they're trying known used passwords. But good on you doing what you can to contribute to the project!
There should be an error, but it shouldn't say whether it was the email or password that was wrong.
Fair point!
An attacker would still know the account exists, and they would know the password did not match.
_Or_ you're assuring them that specific password is used by some account, just not this one. Which is even worse.
Read the comment you're responding to, again. Nothing about their suggestion leads to either of these scenarios.
Right, I misread "shouldn't" for "should".
Couldn't they just check instancename/u/accountname to see if the user exists?
Theoretically yeah. Depends on how quickly the attacker is working or if they have enough information to know where the account lives. If they're doing their due diligence, they could 100% confirm that. But if they aren't, they might just go to a random instance, try logging in, and see if it works.
By no means is it bad to offer a response, but it always risks giving an attacker more information than they need/the victim would want to have discovered about them.
yeeeeaaaaaaaa - see what you can do about hiding viewed content ^*
Sounds like a cool feature. I'm honestly down for doing a good chunk of lemmy-ui dev work as I'm kind of getting rusty in React with my new job being strictly backend these days.
I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp
If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.
If necessary, you could introduce a toggle that's switched off by default until the feature is fully implemented.
ooooOO this is an interesting approach
Yeah man... I am still waiting for that option that reddit has that hides any content you already upvoted/downvoted.
Thank you!
For a moment I thought you meant "Public Relations". 😅
Not a bad idea! The attack vector issue they mention in the PR comments is valid, though. Not displaying those errors gives an attacker no confirmation that a user whose account they're trying to attack exists, if they're trying known used passwords. But good on you doing what you can to contribute to the project!
There should be an error, but it shouldn't say whether it was the email or password that was wrong.
Fair point!
An attacker would still know the account exists, and they would know the password did not match._Or_ you're assuring them that specific password is used by some account, just not this one. Which is even worse.Read the comment you're responding to, again. Nothing about their suggestion leads to either of these scenarios.
Right, I misread "shouldn't" for "should".
Couldn't they just check instancename/u/accountname to see if the user exists?
Theoretically yeah. Depends on how quickly the attacker is working or if they have enough information to know where the account lives. If they're doing their due diligence, they could 100% confirm that. But if they aren't, they might just go to a random instance, try logging in, and see if it works.
By no means is it bad to offer a response, but it always risks giving an attacker more information than they need/the victim would want to have discovered about them.
yeeeeaaaaaaaa - see what you can do about hiding viewed content ^*
Sounds like a cool feature. I'm honestly down for doing a good chunk of
lemmy-uidev work as I'm kind of getting rusty in React with my new job being strictly backend these days.I might look into it myself, definitely curious but i’m always cautious with open source projects when committing a decently sized PR - yea that’s a great way to keep the knives sharp
If the size of the PR is a concern, maybe the maintainers will allow a staged approach. Create an Issue describing the feature and indicate step by step how you would implement. Then break the work into multiple pull requests.
If necessary, you could introduce a toggle that's switched off by default until the feature is fully implemented.
ooooOO this is an interesting approach
Yeah man... I am still waiting for that option that reddit has that hides any content you already upvoted/downvoted.
Thank you!
For a moment I thought you meant "Public Relations". 😅
Or "Press Release".