Why does the for loop repeat in this recursion?

Why does the for loop repeat after it exits to print a new line? If it exits the loop, shouldn't it be done with it?

There's the new line after the for loop to make sure that the next recursion starts on a fresh line. Otherwise the next recursion would print on the same line, right where it left off, and you'd just have a line of "#"'s. The for loop itself is just for printing "#"'s.

Why is n incremented and not i as stated with i++?

I think this is a confusion with the recursion. Look at the line with draw(n - 1); this happens before any printing of hashes happens, and only continues after its done. And it calls itself as long as it's not less than or equal to 0. To psuedo-code the order of operations here:

draw 3 {
    draw 2 {
        draw 1 {
            draw 0 {};
            print "#" * 1;
        };
        print "#" * 2;
    };
    print "#" *3;
};

so n is never incremented as you think, it just calls decremented versions of the draw function before the current one finishes. The i's are purely involved in the for loop, which only prints hashes. Does that make sense?

This code has a recursive call (function calls itself) within the function so that has to be taken into account when tracing it

This would make the function execute multiple times so the for loop would end up executing multiple times.

Lets say main calls draw with a height value of 10 (draw(10)). First it sees that n is greater than 0 so it keeps going. Then it calls the draw function with a value of 10 - 1 aka 9. Now its executing in the draw(9) function. Greater than 0 so continues and calls draw(8). etc. all the way down to draw(0) where it sees that n is equal to 0 so returns out of the function due to the return statement.

Now that draw(0) finished executing draw(1) can keep going and goes to the for loop. Here it prints 1 # and then prints a new line (and then returns since it hit the end of the function). Now that draw(1) is done draw(2) can keep going and prints 2 #'s and then prints a new line (and then returns). This keeps going all the way up to the initial draw call, draw(10) which prints 10 #'s and then a new line, returns, and then the main function keeps going but theres nothing after that so it returns and the execution ends.

The effect from coming back after the recursive calls makes it seem like n is increasing but its just different calls to the same function. i is taken into account for but printing the amount of #'s since thats whats within that loop

So you're drawing a triangle of # that starts skinny in the top left and grows to the right with a height and width of n?

As an example, Height 3 would be:

#
##
###

I'm not following your questions, but the code seems pretty reasonable... though the use of recursion feels pretty unnecessary when you could easily just use a nested for loop.

Recursion is often unintuitive for beginners, to understand this code we should simply it a bit

int main(void)
{
    int height = get_int("Height: ");

    draw(height);
}

void draw(int n)
{
    if (n <= 0)
    {
        return;
    }

    draw(n - 1);
    printf("%d",  n);
    
    printf("\n");
}

Inputting 3 should now give us a output like

1
2
3 

Try to understand that case first and than muddle it up with the loop.

If you examine it in a debugger look at the Stack trace. If you use gdb its bt in a visual debugger it's probably the list of function names next to the variables

You are looking at a recursive method, as you can see with the line draw(n-1) inside the draw(n) method. You can search for "recursive function" on internet for a better understanding.

Basically, the method draw is called a first time n = a user input, but then this method call itself with n-1 until it reach 0. So you can think as if function draw(6) will call draw(5) and wait for it to return before continuing, draw(5) call draw(4), ect until draw(0) that return immediately.

So then the order of execution will be draw(1) that print " #\n" and return, then draw(2) will proceed to print "##\n" and return, then draw(3), ect until draw(n).

Try moving draw(n-1) after the for loop and see how that changes the output.

Recursion is a little easier to understand if you use goto instead of functions. Functions are a high level concept in the C language (and most other languages) but it gets compiled down to (essentially) the older goto style of programming.

Most modern languages don't even have goto support, since functions are generally more reliable, however as a programmer you should be aware what's going on under the hood. Here's your code rewritten to use goto (I also generally rewrote the whole thing to be a bit easier to grok):

int main(void)
{
    int height = get_int("Height: ");
    int row = 1;
    int col = 0;

draw:
    if (row > height)
    {
        goto end;
    }

    if (col < row)
    {
        printf("#");
        col++;
        goto draw;
    }
    
    // Move to the next row
    printf("\n");
    row++;
    col = 0;
    goto draw;

end:
    return 0;
}

Another approach to thinking about it is that draw() does two things. 1) it draws the line that's 1 shorter than itself, then 2) it draws itself.

The for loop happens after it draws the line that's 1 shorter than itself.

Recursion is much easier to understand if you use goto instead of functions. Functions are a high level concept in the C language (and most other languages) but it gets compiled down to (essentially) the older goto style of programming which is much easier to understand.

goto 42 will move execution to line 42 of the code. goto x will move to the line of code labeled x.

Most modern languages don't even have goto support, since functions are cleaner and tend to produce more easily maintained code, however as a programmer you should be aware what's going on under the hood. Here's your code rewritten to use goto:

int main(void)
{
    int height = get_int("Height: ");
    int row = 1; // Starting row
    int col = 0; // Starting column

draw:
    if (row > height) // Exit condition
    {
        goto end;
    }

    if (col < row)
    {
        printf("#");
        col++;
        goto draw; // Repeat the same row
    }
    
    // Move to the next row
    printf("\n");
    row++;
    col = 0; // Reset column for the next row
    goto draw;

end:
    return 0;
}

PS: goto is also how for loops, if statements, switch blocks and others work under the hood.