Programming as a hobby means I can do whatever I want!

Thelie@sh.itjust.works to Programmer Humor@programming.dev – 230 points –
22

I have to say, I'm getting more and more frustrated by the bad code I have to write due to bad business circumstances.

I want clean, readable code with proper documentation and at least a bit of internal consistency and not the shoehorned mess of hacks, todos and weird corner cases.

todos

I found a simple trick against this: just remove them. Accept it ain’t gonna happen man.

Well, yes, but the underlying issues still persist, so it's not exactly a sustainable strategy.

It’s mostly a joke, but often when I find todos they’re so old they’re no longer relevant.

Of course you shouldn’t blindly remove todos.

Don't just put "TODO". If they're in the final pull request, they need to mention a ticket that's intended to fix that TODO. If you/your team decides it's not important, then remove it and close out the ticket. Either way, you're required to do something with it.

At least the code on the bottom is actual code and not just signatures

Instead of

if let Some(a_) = a{
    ()
} else if let Some(b_)=b{
    ()
} else {
    dostuff 
}

you could just use

if a.isNone()&&b.isNone(){
    dostuff
}

Also if you don't use the value in a match just use _

Also you can use enums insteas of string literals

I'm not sure how I would go about this in an elegant way since I'm matching the string I get from a message…

If the message used enums for actions/procedures like SPAM_MEMES, then using enums would be more performant

I think you'd be happy to know that I've gone for a bit of an overkill and used Pest to parse the commands, which automagically gets me an enum to match against in this position.

The sad part is, I haven't gotten the Media upload to work, so the project is on ice for a little while…

That's a good point, thanks. Maybe I'll go without the if entirely, the (janky) code is still very much in flux ;)

I don't nearly know enough to understand this but is anyone willing to help me get the thing on the top :>

To first give you some context, the thing on the top is from The "Representable Functors" chapter of Category Theory for Programmers. So technically, you only need to read 230 Pages of a maths textbook to get it ;)

But this isn't exactly what you asked for, so I'll try to help you get it as best I can with my limited understanding of the subject. First of all it would be helpful to know what your prior knowledge in Maths, especially Set theory, is?